fix: improve URL serialization and query string handling#347
Merged
Conversation
… encodeURI to avoid issues with slash serialization in parameters
…e URLSearchParams power instead of the custom implementation weakness
…tead of `encodeURI` to avoid issues with slash serialization in path parameters.
🦋 Changeset detectedLatest commit: 6a84635 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
radist2s
force-pushed
the
fix/url-serializer
branch
from
f803fde to
11439cf
Compare
…archParams instead of custom implementation for better maintainability.
radist2s
force-pushed
the
fix/url-serializer
branch
from
11439cf to
6a84635
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two improvements to URL handling in the React client:
Changes
encodeURIwithencodeURIComponentto properly handle slash serialization in path parametersgetQueryStringimplementation with nativeURLSearchParamsfor better maintainability